Add semantic versioning validator to _Versioned mixin #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahouseholder
added
enhancement
ahouseholder
requested review from
cgyarbrough and
sei-vsarvepalli
as code owners
sei-vsarvepalli
approved these changes
Feb 19, 2025
ahouseholder
deleted the
347-add-regex-check-for-semver-formatting-in-versioned-python-objects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes advantage of our switch to pydantic data classes in #674 to add a field validator on the
_Versionedmixin class that enforces valid semver strings in theversionattribute.Copilot summary
This pull request includes updates to the
src/ssvc/_mixins.pyfile to improve version validation by adding a new dependency and a validation method.Validation improvements:
src/ssvc/_mixins.py: Addedsemverlibrary import to handle version parsing and validation.src/ssvc/_mixins.py: Introduced avalidate_versionmethod in the_Versionedclass usingfield_validatorto ensure theversionfield is a valid version number. This method parses the version string and raises aValueErrorif it is not valid.